Add HomeLink integration #136460
Add HomeLink integration #136460
Conversation
There was a problem hiding this comment.
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
There was a problem hiding this comment.
thanks for taking the time to contribute that integration!
Before we can get started with the actual review process there is one thing to sort out: We require our 3rd party libraries to be hosted in public repositories, with an OSI approved license and tagged releases, which get deployed to PyPi through CICD. I wasn't able to find the source code of the library (as in the actual repo, not pypi), can you point me to it?
@zweckj I have updated the PR description to point to the public repo for our Python package code. Here's a direct link: https://github.com/Gentex-Corporation/homelink-home-assistant |
ef4b132 to
9a5072f
Compare
| "user": { | ||
| "data": { | ||
| "email": "Email Address", | ||
| "password": "Password" |
There was a problem hiding this comment.
You can replace these two with common strings, too:
"[%key:common::config_flow::data::email%]"
"[%key:common::config_flow::data::password%]"
Saves us translators a bit of work. ;-)
There was a problem hiding this comment.
Thanks @NoRi2909, I've made the change here, does this also need to change for the data_description fields further down?
There was a problem hiding this comment.
Hello @ryanjones-gentex,
When attempting to inspect the commits of your pull request for CLA signature status among all authors we encountered commit(s) which were not linked to a GitHub account, thus not allowing us to determine their status(es).
The commits that are missing a linked GitHub account are the following:
3fbabf2e6b8d55635b7f3ec1c86231fbd4460ecb- This commit has something that looks like an email address (ryan.jones+github@gentex.com). Maybe try linking that to GitHub?.
Unfortunately, we are unable to accept this pull request until this situation is corrected.
Here are your options:
-
If you had an email address set for the commit that simply wasn't linked to your GitHub account you can link that email now and it will retroactively apply to your commits. The simplest way to do this is to click the link to one of the above commits and look for a blue question mark in a blue circle in the top left. Hovering over that bubble will show you what email address you used. Clicking on that button will take you to your email address settings on GitHub. Just add the email address on that page and you're all set. GitHub has more information about this option in their help center.
-
If you didn't use an email address at all, it was an invalid email, or it's one you can't link to your GitHub, you will need to change the authorship information of the commit and your global Git settings so this doesn't happen again going forward. GitHub provides some great instructions on how to change your authorship information in their help center.
- If you only made a single commit you should be able to run
(substituting "Author Name" and "
git commit --amend --author="Author Name <email@address.com>"email@address.com" for your actual information) to set the authorship information. - If you made more than one commit and the commit with the missing authorship information is not the most recent one you have two options:
- You can re-create all commits missing authorship information. This is going to be the easiest solution for developers that aren't extremely confident in their Git and command line skills.
- You can use this script that GitHub provides to rewrite history. Please note: this should be used only if you are very confident in your abilities and understand its impacts.
- Whichever method you choose, I will come by to re-check the pull request once you push the fixes to this branch.
- If you only made a single commit you should be able to run
We apologize for this inconvenience, especially since it usually bites new contributors to Home Assistant. We hope you understand the need for us to protect ourselves and the great community we all have built legally. The best thing to come out of this is that you only need to fix this once and it benefits the entire Home Assistant and GitHub community.
Thanks, I look forward to checking this PR again soon! ❤️
There was a problem hiding this comment.
Hello @ryanjones-gentex,
When attempting to inspect the commits of your pull request for CLA signature status among all authors we encountered commit(s) which were not linked to a GitHub account, thus not allowing us to determine their status(es).
The commits that are missing a linked GitHub account are the following:
3fbabf2e6b8d55635b7f3ec1c86231fbd4460ecb- This commit has something that looks like an email address (ryan.jones+github@gentex.com). Maybe try linking that to GitHub?.
Unfortunately, we are unable to accept this pull request until this situation is corrected.
Here are your options:
-
If you had an email address set for the commit that simply wasn't linked to your GitHub account you can link that email now and it will retroactively apply to your commits. The simplest way to do this is to click the link to one of the above commits and look for a blue question mark in a blue circle in the top left. Hovering over that bubble will show you what email address you used. Clicking on that button will take you to your email address settings on GitHub. Just add the email address on that page and you're all set. GitHub has more information about this option in their help center.
-
If you didn't use an email address at all, it was an invalid email, or it's one you can't link to your GitHub, you will need to change the authorship information of the commit and your global Git settings so this doesn't happen again going forward. GitHub provides some great instructions on how to change your authorship information in their help center.
- If you only made a single commit you should be able to run
(substituting "Author Name" and "
git commit --amend --author="Author Name <email@address.com>"email@address.com" for your actual information) to set the authorship information. - If you made more than one commit and the commit with the missing authorship information is not the most recent one you have two options:
- You can re-create all commits missing authorship information. This is going to be the easiest solution for developers that aren't extremely confident in their Git and command line skills.
- You can use this script that GitHub provides to rewrite history. Please note: this should be used only if you are very confident in your abilities and understand its impacts.
- Whichever method you choose, I will come by to re-check the pull request once you push the fixes to this branch.
- If you only made a single commit you should be able to run
We apologize for this inconvenience, especially since it usually bites new contributors to Home Assistant. We hope you understand the need for us to protect ourselves and the great community we all have built legally. The best thing to come out of this is that you only need to fix this once and it benefits the entire Home Assistant and GitHub community.
Thanks, I look forward to checking this PR again soon! ❤️
| self.last_sync_timestamp = None | ||
| self.last_sync_id = None |
Feature/pubsub
Feature/ha changes
|
@zweckj Are there any more changes you'd like us to make for the integration (once we fix the MyPy issue in the pipeline)? |
|
I'm not comfortable reviewing this further, because
so someone from the core team needs to take it from here |
@zweckj is there anything else we need to do for a core team member to review this PR? This is our first time going through adding an integration and we want to make sure we're doing everything we can to comply with the process. |
|
no, it's just waiting for now unfortunately |
Breaking change
Proposed change
Add custom integration for HomeLink devices to interact with Home Assistant.
This integration is dependent on the homelink-home-assistant python package, which has been added to the appropriate
requirementsfiles. The code for the package is hosted here: https://github.com/Gentex-Corporation/homelink-home-assistantType of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: