Ask for PIN in Husqvarna Automower BLE integration #135440
Open
+430
−78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d7a234e to
86f32fd
Compare
joostlek
requested changes
Jan 13, 2025
homeassistant/components/husqvarna_automower_ble/config_flow.py
Outdated
Show resolved
Hide resolved
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
Oh I read the description now (bad habit lol). So I think instead of marking this a breaking change and have people setup their device again, let's create a way to update their configuration. There are 2 ways to do this and I need some more information about the PIN to know which one makes more sense:
|
|
Someone just told me that the PIN can be changed, so I would recommend using a reauth flow to allow the user to provide the new PIN |
0f7f606 to
6b8fb29
Compare
|
I have updated this to use the reauth flow and updated the tests to ensure 100% test coverage on the new flow |
|
Happy to test these changes if that helps. Spring is coming and my mower doesn't work until this change is merged. Would be great to have this merged for the April release! Thanks @alistair23 |
joostlek
requested changes
Mar 17, 2025
a32271c to
4188264
Compare
3b9a149 to
ae5f907
Compare
joostlek
reviewed
Apr 3, 2025
homeassistant/components/husqvarna_automower_ble/config_flow.py
Outdated
Show resolved
Hide resolved
|
Is this still being worked on? Would love to see this in one of the next releases. |
|
Is there a way to cherry pick this change on a normal home assistant install? My mower doesn't work without this |
3b4af00 to
dc779c7
Compare
alistair23
added a commit
to alistair23/homeassistant-core
that referenced
this pull request
May 14, 2025
Simplify the config flow so that we follow the same method for both Bluetooth discovery and manual setup. This should address: home-assistant#135440 (comment) Signed-off-by: Alistair Francis <alistair@alistair23.me>
dc779c7 to
18d01e0
Compare
alistair23
added a commit
to alistair23/homeassistant-core
that referenced
this pull request
May 14, 2025
Simplify the config flow so that we follow the same method for both Bluetooth discovery and manual setup. This should address: home-assistant#135440 (comment) Signed-off-by: Alistair Francis <alistair@alistair23.me>
18d01e0 to
4c7c982
Compare
alistair23
added a commit
to alistair23/homeassistant-core
that referenced
this pull request
May 14, 2025
Simplify the config flow so that we follow the same method for both Bluetooth discovery and manual setup. This should address: home-assistant#135440 (comment) Signed-off-by: Alistair Francis <alistair@alistair23.me>
4c7c982 to
d0ce5ac
Compare
All Automowers are setup with a 4 digit PIN. Depending the the model of the Automower and the security level set on the device by the user the PIN is required at boot and when performing certain operations. The current Home Assistant integration doesn't require a PIN for certain models. It seems like higher security levels or certain models always require a PIN though. So the integration currently doesn't work for all models or configurations. As such, let's request a PIN from users when setting up the integration so that we can use that for communicating with the mower. This should make the integration more robust for a range of different models and security levels as we can send the PIN as part of the BLE setup. Fixes: home-assistant#131321 Signed-off-by: Alistair Francis <alistair@alistair23.me>
Signed-off-by: Alistair Francis <alistair@alistair23.me>
Signed-off-by: Alistair Francis <alistair@alistair23.me>
… errors Signed-off-by: Alistair Francis <alistair@alistair23.me>
Signed-off-by: Alistair Francis <alistair@alistair23.me>
Signed-off-by: Alistair Francis <alistair@alistair23.me>
Signed-off-by: Alistair Francis <alistair@alistair23.me>
Signed-off-by: Alistair Francis <alistair@alistair23.me>
Simplify the config flow so that we follow the same method for both Bluetooth discovery and manual setup. This should address: home-assistant#135440 (comment) Signed-off-by: Alistair Francis <alistair@alistair23.me>
Signed-off-by: Alistair Francis <alistair@alistair23.me>
d0ce5ac to
b9a558a
Compare
|
@joostlek |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
2C19
Suggestion cannot be applied right now. Please check back later.
Breaking change
The integration now requires the AutoMower PIN when being setup. This ensure Home Assistant can communicate with more models of Mowers and with higher security levels.
Proposed change
All Automowers are setup with a 4 digit PIN. Depending the the model of the Automower and the security level set on the device by the user the PIN is required at boot and when performing certain operations.
The current Home Assistant integration doesn't require a PIN. It seems like higher security levels or certain models always require a PIN though. So the integration currently doesn't work for all models or configurations.
As such, let's request a PIN from users when setting up the integration so that we can use that for communicating with the mower. This should make the integration more robust for a range of different models and security levels as we can send the PIN as part of the BLE setup.
Fixes: #131321
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: