Add actronairneo climate integration #134740
Conversation
There was a problem hiding this comment.
Hello @kclif9,
When attempting to inspect the commits of your pull request for CLA signature status among all authors we encountered commit(s) which were not linked to a GitHub account, thus not allowing us to determine their status(es).
The commits that are missing a linked GitHub account are the following:
779c15d9f917fd77a8b23bccf66d699ca964fa50- This commit has something that looks like an email address (kurt@chrisfords.com.au). Maybe try linking that to GitHub?.
Unfortunately, we are unable to accept this pull request until this situation is corrected.
Here are your options:
-
If you had an email address set for the commit that simply wasn't linked to your GitHub account you can link that email now and it will retroactively apply to your commits. The simplest way to do this is to click the link to one of the above commits and look for a blue question mark in a blue circle in the top left. Hovering over that bubble will show you what email address you used. Clicking on that button will take you to your email address settings on GitHub. Just add the email address on that page and you're all set. GitHub has more information about this option in their help center.
-
If you didn't use an email address at all, it was an invalid email, or it's one you can't link to your GitHub, you will need to change the authorship information of the commit and your global Git settings so this doesn't happen again going forward. GitHub provides some great instructions on how to change your authorship information in their help center.
- If you only made a single commit you should be able to run
(substituting "Author Name" and "
git commit --amend --author="Author Name <email@address.com>"email@address.com" for your actual information) to set the authorship information. - If you made more than one commit and the commit with the missing authorship information is not the most recent one you have two options:
- You can re-create all commits missing authorship information. This is going to be the easiest solution for developers that aren't extremely confident in their Git and command line skills.
- You can use this script that GitHub provides to rewrite history. Please note: this should be used only if you are very confident in your abilities and understand its impacts.
- Whichever method you choose, I will come by to re-check the pull request once you push the fixes to this branch.
- If you only made a single commit you should be able to run
We apologize for this inconvenience, especially since it usually bites new contributors to Home Assistant. We hope you understand the need for us to protect ourselves and the great community we all have built legally. The best thing to come out of this is that you only need to fix this once and it benefits the entire Home Assistant and GitHub community.
Thanks, I look forward to checking this PR again soon! ❤️
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
I believe I've implemented all the bronze standard rules. Can you please advise which need to be fixed? |
…nment in constructor
…ic and remove unused status data serialization
…ations for name attributes
…amline error handling
…ateEntity and streamline ActronSystemClimate and ActronZoneClimate classes
…te data handling for improved performance and clarity
| class ActronNeoApiCoordinator: | ||
| """Coordinator for Actron Neo API.""" | ||
|
|
||
| def __init__(self, hass: HomeAssistant, entry: ActronNeoConfigEntry) -> None: | ||
| """Initialize the coordinator.""" | ||
| self.hass = hass | ||
| self.entry = entry | ||
| self.api = ActronNeoAPI(pairing_token=entry.data[CONF_API_TOKEN]) | ||
| self.systems: list[ActronAirNeoACSystem] = [] | ||
|
|
||
| async def async_setup(self) -> bool: | ||
| """Perform initial setup, including refreshing the token.""" | ||
| try: | ||
| await self.api.refresh_token() | ||
| systems = await self.api.get_ac_systems() | ||
| self.systems = systems | ||
| except ActronNeoAuthError: | ||
| _LOGGER.error( | ||
| "Authentication error while setting up Actron Neo integration" | ||
| ) | ||
| raise | ||
| except ActronNeoAPIError as err: | ||
| _LOGGER.error("API error while setting up Actron Neo integration: %s", err) | ||
| raise | ||
| return True |
There was a problem hiding this comment.
Why do we have this separate class? Can we merge it with the coordinator?
There was a problem hiding this comment.
I separated it into its own class as the same API endpoint can return multiple systems. It made sense to me to break it into two separate classes such that the initial step in initalisation connects to the API and retrieves systems, then the second step creates the classes for the system coordinators.
This way there cannot be any confusion between having multiple API endpoints (such as if you have two Actron Neo accounts) and multiple systems
There was a problem hiding this comment.
How do you mean the second step? currently I kinda see this as a wrapper for the client, and a part of a data holder, which is a role that the coordinator already has
There was a problem hiding this comment.
In the init file, I connect to the API to pull in the systems that are connected to the account, then have a separate coordinator instance for each system. This significantly reduces the complexity of the integration.
My concern behind merging them back together, and together with your previous recommendations around simplifying the coordinator, it may get complicated if I'm instantiating a coordinator, then creating additional instances for multiple systems. Separating the logic for the two makes sense to me as they do serve separate purposes, and makes it easier when you have multiple systems under a single account.
To make the naming clearer, I've renamed the ApiCoordinator to ApiClient as that reflects more accurately what its purpose is. Are you okay with this approach?
…treamline temperature property access
Proposed change
Contribute a new integration to Home Assistant - Actron Air Neo. This PR pertains to the Climate platform.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: