8000 Add power protection entities for tplink by rytilahti · Pull Request #132267 · home-assistant/core · GitHub
[go: up one dir, main page]
Skip to content

Add power protection entities for tplink #132267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 29, 2025
Merged

Add power protection entities for tplink #132267

merged 5 commits into from
Jan 29, 2025

Conversation

rytilahti
Copy link
Member
@rytilahti rytilahti commented Dec 4, 2024 •
edited
Loading

Proposed change

Add power protection entities for supported devices.
This feature allows specifying a power threshold where the device turns itself off.
If that happens, the "Overloaded" entity is set to indicate the problem. This will remain until the device gets turned again back on.

image

Depends on python-kasa/python-kasa#1337

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link
home-assistant bot commented Dec 4, 2024

Hey there @bdraco, @sdb9696, mind taking a look at this pull request as it has been labeled with an integration (tplink) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of tplink can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign tplink Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

This was referenced Dec 4, 2024
Merged
Closed
sdb9696
sdb9696 suggested changes Jan 28, 2025
View reviewed changes
Copy link
Contributor
@sdb9696 sdb9696 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to remove the power_protection_enabled is it's now all wrapped up in the threshold feature. A couple of other minor nits, otherwise this looks ready to go.

@rytilahti rytilahti marked this pull request as ready for review January 28, 2025 20:34
@rytilahti rytilahti requested a review from bdraco as a code owner January 28, 2025 20:34
@rytilahti
Copy link
Member Author

The missing coverage seems to be unrelated and caused by merging the current dev to this.

bdraco
bdraco reviewed Jan 28, 2025
View reviewed changes
@bdraco bdraco marked this pull request as draft January 29, 2025 00:27
@bdraco
Copy link
Member
bdraco commented Jan 29, 2025

Needs conflicts resolved

@bdraco bdraco marked this pull request as ready for review January 29, 2025 05:29
@bdraco bdraco added the smash Indicator this PR is close to finish for merging or closing label Jan 29, 2025
@bdraco bdraco merged commit 94e4863 into dev Jan 29, 2025
28 checks passed
@bdraco bdraco deleted the tplink/power_protect branch January 29, 2025 05:34
zxdavb pushed a commit to zxdavb/hass that referenced this pull request Jan 29, 2025
@rytilahti @sdb9696
@bdraco @zxdavb
Add power protection entities for tplink (home-assistant#132267)
32e8f9c 
Co-authored-by: Steven B <51370195+sdb9696@users.noreply.github.com>
Co-authored-by: J. Nick Koston <nick@koston.org>
zxdavb pushed a commit to zxdavb/hass that referenced this pull request Jan 29, 2025
@rytilahti @sdb9696
@bdraco @zxdavb
Add power protection entities for tplink (home-assistant#132267)
dcb3c71 
Co-authored-by: Steven B <51370195+sdb9696@users.noreply.github.com>
Co-authored-by: J. Nick Koston <nick@koston.org>
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sdb9696 sdb9696 sdb9696 requested changes

@bdraco bdraco bdraco approved these changes

Assignees

@bdraco bdraco

Labels
by-code-owner cla-signed has-tests integration: tplink new-feature Quality Scale: No score small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Milestone
No milestone
Development

Successfully me 3AA9 rging this pull request may close these issues.
3 participants
@rytilahti @bdraco @sdb9696
0