8000 Add child lock for tplink thermostats by rytilahti · Pull Request #129649 · home-assistant/core · GitHub
[go: up one dir, main page]
Skip to content

Add child lock for tplink thermostats #129649

8000
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2024
Merged

Add child lock for tplink thermostats #129649

merged 1 commit into from
Nov 5, 2024

Conversation

rytilahti
Copy link
Member
@rytilahti rytilahti commented Nov 1, 2024 •
edited
Loading

Proposed change

This PR adds a child lock switch for tplink thermostats.

Marking as draft as this depends on python-kasa/python-kasa#1141 .

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@rytilahti rytilahti added the waiting-for-upstream We're waiting for a change upstream label Nov 1, 2024
@home-assistant
Copy link
home-assistant bot commented Nov 1, 2024

Hey there @bdraco, @sdb9696, mind taking a look at this pull request as it has been labeled with an integration (tplink) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of tplink can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign tplink Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@rytilahti
Copy link
Member Author

Required version bump shipped in #129817, so marking this as ready for review.

@rytilahti rytilahti marked this pull request as ready for review November 4, 2024 23:17
@rytilahti rytilahti requested a review from bdraco as a code owner November 4, 2024 23:17
@joostlek joostlek removed the waiting-for-upstream We're waiting for a change upstream label Nov 5, 2024
@joostlek joostlek merged commit 72bcc67 into dev Nov 5, 2024
32 checks passed
@joostlek joostlek deleted the tplink/feat/child_lock branch November 5, 2024 10:14
@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joostlek joostlek joostlek approved these changes

@bdraco bdraco Awaiting requested review from bdraco bdraco is a code owner

Assignees

@bdraco bdraco

Labels
by-code-owner cla-signed has-tests integration: tplink new-feature Quality Scale: platinum small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rytilahti @joostlek @bdraco
0