Add motion sensor setting to tplink #129393
Conversation
|
Hey there @bdraco, @sdb9696, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
|
Required version bump shipped in #129817, so marking this as ready for review. |
| "pir_enabled": { | ||
| "name": "PIR enabled" |
There was a problem hiding this comment.
It feels strange to call this PIR enabled, since it's not enabled, the switch decides if its enabled
There was a problem hiding this comment.
IMO, this is correct. The goal of this PR is to control the state of the motion sensor in the switch (enabled/disabled). This is a user setting, and the user decides if PIR should be enabled or disabled for the switch. You can control it from the Kasa app, and with this PR you can also control it via HA.
Here is how it looks in the Kasa app:
Instead of PIR enabled we can name it Motion Sensor for consistency. But I'm fine with any name.
There was a problem hiding this comment.
Fixed conflicts and renamed this to "Motion sensor". It is not consistent with some other X enabled switches, but it's more understandable than rather technical PIR so I think it's an improvement.
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Proposed change
This PR adds a new switch to control the motion detection sensor found on some dimmers.
Related upstream PR: python-kasa/python-kasa#1174
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: