Migrate tplink integration to new module-based library api #117839
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @rytilahti, @TheGardenMonkey, @bdraco, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
sdb9696
commented
May 21, 2024
Comment on lines
365
to
+368
| # If there is an effect in progress | ||
| # we have to set an HSV value to clear the effect | ||
| # we have to clear the effect | ||
| # before we can set a color temp | ||
| await self.device.set_hsv(0, 0, brightness) | ||
| await self._light_module.set_hsv(0, 0, brightness) |
There was a problem hiding this comment.
It might also be possible to call LightEffect.set_effect(LightEffect.LIGHT_EFFECTS_OFF) here but that needs to be tested with an iot` lightstrip.
There was a problem hiding this comment.
Something that can be done in the light platform rewrite.
Comment on lines
104
to
108
| """Test no migration happens if the original entity id still exists.""" | ||
| config_entry = MockConfigEntry(domain=DOMAIN, data={}, unique_id=MAC_ADDRESS) | ||
| config_entry.add_to_hass(hass) | ||
| dimmer = _mocked_dimmer() | ||
| dimmer = _mocked_device(alias="My dimmer", modules=[Module.Light]) | ||
| rollout_unique_id = MAC_ADDRESS.replace(":", "").upper() |
There was a problem hiding this comment.
This test does not appear to work as I haven't set the device type to dimmer and it still passes (maybe because it's creating the migrated entity entry?). Although I notice the async_fix_dimmer_unique_id function added in #57346 is no longer present so maybe the test is redundant?
Also to get the async_setup_component to properly run I had to add wait_background_tasks=True so I wonder if we need to be adding that in other tests as well.
rytilahti
reviewed
May 21, 2024
rytilahti
pushed a commit
to python-kasa/python-kasa
that referenced
this pull request
May 22, 2024
PR contains a number of fixes from testing with HA devices: - Fixes a bug with turning the light on and off via `set_state` - Aligns `set_brightness` behaviour across `smart` and `iot` devices such that a value of 0 is off. - Aligns `set_brightness` behaviour for `IotDimmer` such that setting the brightness turns on the device with a transition of 1ms. ([HA comment](home-assistant/core#117839 (comment))) - Fixes a typing issue in `LightState`. - Adds `ColorTempRange` and `HSV` to `__init__.py` - Adds a `state` property to the interface returning `LightState` for validating `set_state` changes. - Adds tests for `set_state`
rytilahti
approved these changes
May 22, 2024
| @@ -312,19 +327,29 @@ def _handle_coordinator_update(self) -> None: | |||
| class TPLinkSmartLightStrip(TPLinkSmartBulb): | |||
| """Representation of a TPLink Smart Light Strip.""" | |||
|
|
|||
| device: SmartLightStrip | |||
| def __init__( | |||
There was a problem hiding this comment.
We can get rid of this now, but that's something for the light platform rewrite 👍
Comment on lines
365
to
+368
| # If there is an effect in progress | ||
| # we have to set an HSV value to clear the effect | ||
| # we have to clear the effect | ||
| # before we can set a color temp | ||
| await self.device.set_hsv(0, 0, brightness) | ||
| await self._light_module.set_hsv(0, 0, brightness) |
There was a problem hiding this comment.
Something that can be done in the light platform rewrite.
rytilahti
added a commit
that referenced
this pull request
May 22, 2024
* Bump version to 0.7.0.dev0 * Convert SmartDeviceException->KasaException, SmartDevice->Device * Implement feature-based entities & convert switch platform over * Allow passing kwargs to descriptions * Disable all but explicitly enabled debug features per default * Convert SmartDeviceException->KasaException, SmartDevice->Device * Migrate tplink integration to new common module kasa library api * Add has_custom_effects check * Remove NO_SWITCH_DEVICE_MODULES const * Remove led test stuff * Migrate tplink integration to new module-based library api (#117839) Migrate the tplink integration to the new common module format of the kasa library api. Also includes a small dependency bump to pick up some bugfixes found during testing: https://github.com/python-kasa/python-kasa/releases/tag/0.7.0.dev1 See #117785 for an explanation of the approach for merging into the `tplink_rewrite` branch. --------- Co-authored-by: Teemu Rytilahti <tpr@iki.fi> * Remove leftover no switch module const --------- Co-authored-by: Teemu Rytilahti <tpr@iki.fi>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Migrate the tplink integration to the new common module format of the kasa library api.
Also includes a small dependency bump to pick up some bugfixes found during testing:
https://github.com/python-kasa/python-kasa/releases/tag/0.7.0.dev1
See #117785 for an explanation of the approach for merging into the
tplink_rewritebranch.Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: