8000 Add first TypeVarTuple annotations by cdce8p · Pull Request #105379 · home-assistant/core · GitHub
[go: up one dir, main page]
Skip to content

Add first TypeVarTuple annotations #105379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 17, 2023
Merged

Add first TypeVarTuple annotations #105379

merged 1 commit into from
Dec 17, 2023

Conversation

cdce8p
Copy link
Member
@cdce8p cdce8p commented Dec 9, 2023 •
edited
Loading

Proposed change

Now that both mypy and pyright support TypeVarTuple, we can start to use it to annotate callbacks which only accept *args. Something quite commonly use for asyncio callback functions. See python/typeshed#11015 for a few more examples with call_soon and others. These will be included in a future mypy release - probably in January.

One thing to consider: even though the typing is correct, there is an existing bug in pyright when functions with default arguments are passed. It has already been fixed but will only be included in the next Pylance release. So for the time being those emit false-positives.

Update: Fixed with pre-release version v2023.12.100.

Screenshot 2023-12-09 at 12 23 32

core/homeassistant/core.py

Lines 1191 to 1193 in d54c363

async_remove_listener = run_callback_threadsafe(
self._hass.loop, self.async_listen, event_type, listener
).result()

Ref: microsoft/pyright#6613

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/chang 8000 ed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@cdce8p cdce8p requested a review from a team as a code owner December 9, 2023 11:27
@home-assistant home-assistant bot added cla-signed code-quality core small-pr PRs with less than 30 lines. labels Dec 9, 2023
@cdce8p cdce8p requested a review from frenck December 9, 2023 11:28
MartinHjelmare
MartinHjelmare approved these changes Dec 17, 2023
View reviewed changes
Copy link
Member
@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare merged commit aac02d7 into home-assistant:dev Dec 17, 2023
@cdce8p cdce8p deleted the add-first-Ts branch December 18, 2023 03:52
Bre77 pushed a commit to Bre77/core that referenced this pull request Dec 18, 2023
@cdce8p @Bre77
Add first TypeVarTuple annotations (home-assistant#105379)
02d1e9d
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

@frenck frenck Awaiting requested review from frenck

Assignees
No one assigned
Labels
cla-signed code-quality core small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cdce8p @MartinHjelmare
0