Ensure discrete events are always scheduled after change events #8319
Conversation
There was a problem hiding this comment.
Pull request overview
This PR ensures that discrete events (e.g., button clicks, table edits) are always scheduled and processed after change events (e.g., property updates) have completed, preventing race conditions where event handlers could execute before all property changes have been applied.
Key changes:
- Modified
_event_coroutineto preserve change callbacks instate._change_callbacksduring processing instead of immediately removing them - Added cleanup logic in
_change_coroutineto remove empty callback dictionaries after processing - Enhanced
_server_eventto check for pending change callbacks and defer discrete events when changes are still being processed
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8319 +/- ##
==========================================
+ Coverage 85.41% 86.01% +0.59%
==========================================
Files 348 348
Lines 54592 54594 +2
==========================================
+ Hits 46629 46958 +329
+ Misses 7963 7636 -327 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Ensures that discrete events are always scheduled after change events have been processed. In certain scenarios this was not previously the case.
Fixes #8311