10BC0 type: Fix type checking by hoxbro · Pull Request #8314 · holoviz/panel · GitHub
[go: up one dir, main page]
Skip to content

type: Fix type checking #8314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
philippjfr merged 1 commit into from
Dec 1, 2025
Merged

type: Fix type checking #8314

philippjfr merged 1 commit into from
Dec 1, 2025

Conversation

@hoxbro
Copy link
Member
@hoxbro hoxbro commented Dec 1, 2025

This was indirectly imported via import bokeh.core.properties as bp, which made it work, but a new release of mypy now flags this as an error.

@codecov
Copy link
codecov bot commented Dec 1, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.26%. Comparing base (42b0956) to head (498449f).
⚠️ Report is 4 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (42b0956) and HEAD (498449f). Click for more details.

HEAD has 37 uploads less than BASE
Flag BASE (42b0956) HEAD (498449f)
45 8
Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #8314       +/-   ##
===========================================
- Coverage   85.99%   70.26%   -15.74%     
===========================================
  Files         348      347        -1     
  Lines       54457    54469       +12     
===========================================
- Hits        46832    38272     -8560     
- Misses       7625    16197     +8572

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@philippjfr
Copy link
Member
philippjfr commented Dec 1, 2025

Not sure what's up with the JupyterLite UI tests yet, but that's a separate issue. Merging.

@philippjfr philippjfr merged commit f55a9ab into main Dec 1, 2025
15 of 21 checks passed
@philippjfr philippjfr deleted the type_fix branch December 1, 2025 10:50
@hoxbro
Copy link
Member Author
hoxbro commented Dec 1, 2025

Seems like a new version breaks our lock file hack.

Screenshot From 2025-12-01 11-34-50

@philippjfr philippjfr mentioned this pull request Dec 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@philippjfr philippjfr philippjfr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hoxbro @philippjfr
0