8000 build: Remove bokeh-sampledata for pyodide wheel dependency by hoxbro · Pull Request #8138 · holoviz/panel · GitHub
[go: up one dir, main page]
Skip to content

build: Remove bokeh-sampledata for pyodide wheel dependency #8138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
philippjfr merged 2 commits into from
Aug 19, 2025
Merged

build: Remove bokeh-sampledata for pyodide wheel dependency #8138

philippjfr merged 2 commits into from
Aug 19, 2025
8000

Conversation

@hoxbro
Copy link
Member
@hoxbro hoxbro commented Aug 19, 2025

Resolves #8136

This was added in #6883, not entirely sure why, likely to be compatible with old versions of Bokeh, which included the sampledata.

Likely, we need to update some Jupyterlite notebook too.

@philippjfr
Copy link
Member
philippjfr commented Aug 19, 2025

I think you added it so it would be pulled into our Jupyterlite build, but it should indeed be entirely separate.

@hoxbro
Copy link
Member Author
hoxbro commented Aug 19, 2025

Running the examples without bokeh_sampledata fails the following examples. So will add bokeh_sampledata to these.

FAILED examples/reference/widgets/DataFrame.ipynb::Cell 9
FAILED examples/reference/widgets/Tabulator.ipynb::Cell 31
FAILED examples/reference/widgets/Tabulator.ipynb::Cell 32
FAILED examples/reference/widgets/Tabulator.ipynb::Cell 34
FAILED examples/reference/widgets/Tabulator.ipynb::Cell 35
FAILED examples/reference/widgets/Tabulator.ipynb::Cell 36
FAILED examples/reference/widgets/Tabulator.ipynb::Cell 37
FAILED examples/reference/widgets/Tabulator.ipynb::Cell 46
FAILED examples/reference/widgets/Tabulator.ipynb::Cell 47
FAILED examples/reference/widgets/Tabulator.ipynb::Cell 49
FAILED examples/reference/panes/DataFrame.ipynb::Cell 4
FAILED examples/reference/panes/DataFrame.ipynb::Cell 5
FAILED examples/reference/panes/DataFrame.ipynb::Cell 6
FAILED examples/reference/widgets/FileDownload.ipynb::Cell 4
FAILED examples/reference/widgets/FileDownload.ipynb::Cell 5
FAILED examples/gallery/iris_kmeans.ipynb::Cell 0
FAILED examples/gallery/iris_kmeans.ipynb::Cell 1

@hoxbro hoxbro requested a review from philippjfr August 19, 2025 13:05
@philippjfr philippjfr merged commit 240ef6e into main Aug 19, 2025
33 of 41 checks passed
@philippjfr philippjfr deleted the build_pyodide branch August 19, 2025 14:04
@philippjfr philippjfr mentioned this pull request Sep 5, 2025
Merged
@github-actions
Copy link
github-actions bot commented Dec 2, 2025

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@philippjfr philippjfr philippjfr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The bokeh package on cdn.holoviz.org has a dependency on the sample data

3 participants

@hoxbro @philippjfr
0