10BC0 Ensure Tabulator does not error when editing DataFrame containing NA by philippjfr · Pull Request #8068 · holoviz/panel · GitHub
[go: up one dir, main page]
Skip to content

Ensure Tabulator does not error when editing DataFrame containing NA #8068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
philippjfr merged 2 commits into from
Jul 18, 2025
Merged

Ensure Tabulator does not error when editing DataFrame containing NA #8068

philippjfr merged 2 commits into from
Jul 18, 2025
+11 −7

Conversation

@philippjfr
Copy link
Member
@philippjfr philippjfr commented Jul 18, 2025

Fixes #8063

@codecov
Copy link
codecov bot commented Jul 18, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.09%. Comparing base (7af6d06) to head (ce1c162).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
panel/widgets/tables.py 88.88% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #8068       +/-   ##
===========================================
+ Coverage   71.19%   87.09%   +15.89%     
===========================================
  Files         345      346        +1     
  Lines       53803    53808        +5     
===========================================
+ Hits        38307    46862     +8555     
+ Misses      15496     6946     -8550

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@philippjfr philippjfr merged commit 2f14bcf into main Jul 18, 2025
16 of 18 checks passed
@philippjfr philippjfr deleted the handle_na_tabulator branch July 18, 2025 10:19
philippjfr added a commit that referenced this pull request Jul 21, 2025
@philippjfr
Ensure Tabulator does not error when editing DataFrame containing NA (#…
2baa82c 
…8068)

* Ensure Tabulator does not error when editing DataFrame containing NA values

* Fix test
@github-actions
Copy link
github-actions bot commented Oct 28, 2025

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Tabulator widget fails when pd.DataFrame contains pd.NA

1 participant

@philippjfr
0