Optimize layout calculations for ESM and React components #7989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7989 +/- ##
=======================================
Coverage 87.07% 87.07%
=======================================
Files 346 346
Lines 53374 53374
=======================================
+ Hits 46473 46476 +3
+ Misses 6901 6898 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESM components were still treated as fully managed layouts, i.e. we would perform full layout calculations every time children on an ESM component were rendered. For nested ESM components this meant going up to the root and then triggering a full re-computation from the root on down. Since rendering, particularly in React based components happens asynchronously, these computations would happen many times consecutively.
This PR effectively turns ESM components into un-managed layouts, i.e. they no longer propagate layout changes upwards to parent containers. We also no longer compute BBox and we only trigger a single layout invalidation after all children are rendered.
Potential concerns: