E529 Ensure current view and selection lookups on Tabulator handle None case by philippjfr · Pull Request #7858 · holoviz/panel · GitHub
[go: up one dir, main page]
Skip to content

Ensure current view and selection lookups on Tabulator handle None case #7858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
philippjfr merged 1 commit into from
Apr 17, 2025
Merged

Ensure current view and selection lookups on Tabulator handle None case #7858

philippjfr merged 1 commit into from
Apr 17, 2025

Conversation

@philippjfr
Copy link
Member
@philippjfr philippjfr commented Apr 17, 2025

Fixes #7852

@codecov
Copy link
codecov bot commented Apr 17, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 87.09%. Comparing base (f331909) to head (f26e1f0).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
panel/widgets/tables.py 40.00% 3 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #7858       +/-   ##
===========================================
+ Coverage   47.49%   87.09%   +39.59%     
===========================================
  Files         334      346       +12     
  Lines       50597    53018     +2421     
===========================================
+ Hits        24032    46175    +22143     
+ Misses      26565     6843    -19722

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@philippjfr philippjfr merged commit 7cd5c50 into main Apr 17, 2025
17 of 19 checks passed
@philippjfr philippjfr deleted the tabulator_none_properties branch April 17, 2025 12:06
@philippjfr philippjfr mentioned this pull request Apr 22, 2025
Merged
@github-actions
Copy link
github-actions bot commented Sep 9, 2025

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Tabulator inconsistency type when value is None

2 participants

@philippjfr
0