Fix error when old_objects is empty in _get_objects() #7842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle case where old_objects is empty and _last_synced is set. Prevents exceptions by skipping filtering logic for empty input.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7842 +/- ##
==========================================
- Coverage 87.08% 86.63% -0.45%
==========================================
Files 346 346
Lines 52941 52947 +6
==========================================
- Hits 46102 45873 -229
- Misses 6839 7074 +235 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
philippjfr
approved these changes
Apr 16, 2025
Member
|
Much appreciated! |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle case where old_objects is empty and _last_synced is set.
Prevents exceptions by skipping filtering logic for empty input.
Should fix #7733 and #7818