8000 Make it easier to subclass components by philippjfr · Pull Request #7730 · holoviz/panel · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@philippjfr
Copy link
Member

A number of changes to make it easier to subclass component classes:

  • ChatFeed and ChatInterface component types can now be set as class variables
  • Fix issue falsely detecting a non-instance parameter type as a child
  • Fix incorrectly detecting groups on Select widget

These changes are needed for the work on panel-material-ui so I don't have to reimplement entire classes.

@codecov
Copy link
codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.08%. Comparing base (8f9cc0f) to head (af9a6fa).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7730      +/-   ##
==========================================
- Coverage   87.08%   87.08%   -0.01%     
==========================================
  Files         346      346              
  Lines       52711    52716       +5     
==========================================
+ Hits        45904    45908       +4     
- Misses       6807     6808       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit 2da70d6 into main Feb 25, 2025
18 checks passed
@philippjfr philippjfr deleted the subclass_improvements branch February 25, 2025 13:33
@github-actions
Copy link
github-actions bot commented Sep 9, 2025

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0