Fix ESM component module resolution #7684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7684 +/- ##
==========================================
+ Coverage 86.76% 86.77% +0.01%
==========================================
Files 346 346
Lines 52444 52444
==========================================
+ Hits 45501 45509 +8
+ Misses 6943 6935 -8 ☔ View full report in Codecov by Sentry. |
philippjfr
added a commit
that referenced
this pull request
Feb 12, 2025
* Fix ESM component module resolution * Fix eslint errors
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we used the
Model.nameto determine the name of the JS module inside a bundle. However thenameseemingly is sometimes overwritten making this approach brittle. Instead we now use theclass_nameproperty, which was previously kebab case but is now passed through directly and only transformed into kebab case client-side.