Tweak ChatMessage margins #7310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7310 +/- ##
=======================================
Coverage 82.18% 82.19%
=======================================
Files 337 337
Lines 50380 50394 +14
=======================================
+ Hits 41407 41422 +15
+ Misses 8973 8972 -1 ☔ View full report in Codecov by Sentry. |
philippjfr
approved these changes
Sep 24, 2024
Member
There was a problem hiding this comment.
I really don't think making single pixel adjustments is the correct way to fix this, but for now it's an improvement and I'll merge.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without the divider, the reaction icons were too far left.
Then I noticed that the chat copy icon and reaction icons were misaligned vertically.
I also noticed that the chat copy icon and reaction icons inline spacing were somewhat different (more space between each reaction icon vs reaction icons + chat copy icon)
So I tweaked it all:
Before:
After:
