Ensure Tabulator selection consistency when pagination='local' #7304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippjfr
commented
Sep 20, 2024
6c170e2 to
5498cdc
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7304 +/- ##
==========================================
+ Coverage 82.18% 82.20% +0.01%
==========================================
Files 337 337
Lines 50393 50439 +46
==========================================
+ Hits 41418 41463 +45
- Misses 8975 8976 +1 ☔ View full report in Codecov by Sentry. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When pagination was set to 'local', selections were not being computed correctly when
header_filterswere being applied. Specifically the problem was that theheader_filterswere still being applied on the server, which would cause theselectiongoing out of sync with the data that was visible to the frontend. We fix this by not applyingheader_filterson the server in this scenario, and only when the user accesses thecurrent_viewdo we apply the additional filters so that the view the user sees still matches what is visible on the frontend.