8000 Collection of minor fixes for Panel 1.5.1 by MarcSkovMadsen · Pull Request #7285 · holoviz/panel · GitHub
[go: up one dir, main page]
Skip to content

Collection of minor fixes for Panel 1.5.1 #7285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
philippjfr merged 6 commits into from
Sep 23, 2024
Merged

Collection of minor fixes for Panel 1.5.1 #7285

philippjfr merged 6 commits into from
Sep 23, 2024

Conversation

@MarcSkovMadsen
Copy link
Collaborator
@MarcSkovMadsen MarcSkovMadsen commented Sep 16, 2024 •
edited
Loading
  • fix fastapi example
  • replace iframe embed link in pycafe guide.
  • replace --autoreload with --dev in docs.
  • Add link to AnyWidget Front End Module (AFM) specification.

@hoxbro hoxbro added this to the v1.5.1 milestone Sep 20, 2024
@codecov
Copy link
codecov bot commented Sep 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.20%. Comparing base (32b147d) to head (d62a875).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #7285   +/-   ##
=======================================
  Coverage   82.19%   82.20%           
=======================================
  Files         337      337           
  Lines       50394    50394           
=======================================
+ Hits        41422    41426    +4     
+ Misses       8972     8968    -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

hoxbro
hoxbro reviewed Sep 20, 2024
View reviewed changes
panel/command/serve.py
('--autoreload', dict(
action = 'store_true',
help = "Whether to autoreload source when script changes."
help = "Whether to autoreload source when script changes. We recommend using --dev instead."
Copy link
Member
@hoxbro hoxbro Sep 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is correct for now, but there could be a future where --dev does more than --autoreload

Copy link
Collaborator Author
@MarcSkovMadsen MarcSkovMadsen Sep 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it just for info? Or should I remove the recommendation?

@MarcSkovMadsen MarcSkovMadsen marked this pull request as ready for review September 22, 2024 06:43
@MarcSkovMadsen
Copy link
Collaborator Author
MarcSkovMadsen commented Sep 22, 2024

This PR is growing. So I would like it reviewed and merged while its still possible to review.

@philippjfr
Copy link
Member
philippjfr commented Sep 23, 2024

Happy with this, thanks! I think recommending --dev over --autoreload is fine even if we expand the definition of --dev later.

@philippjfr philippjfr merged commit 85e259e into main Sep 23, 2024
@philippjfr philippjfr deleted the fix/panel-1.5.1 branch September 23, 2024 07:14
@philippjfr philippjfr mentioned this pull request Sep 27, 2024
Merged
@github-actions
Copy link
github-actions bot commented Sep 9, 2025

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
6651

Reviewers

@philippjfr philippjfr philippjfr approved these changes

@hoxbro hoxbro Awaiting requested review from hoxbro

Assignees

No one assigned

Labels

ready for review

Projects

None yet

Milestone

v1.5.1

Development

Successfully merging this pull request may close these issues.

3 participants

@MarcSkovMadsen @philippjfr @hoxbro
0