Annotate Widget params as Any #7132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7132 +/- ##
==========================================
- Coverage 72.39% 72.38% -0.01%
==========================================
Files 326 326
Lines 48827 48827
==========================================
- Hits 35347 35343 -4
- Misses 13480 13484 +4 ☔ View full report in Codecov by Sentry. |
philippjfr
approved these changes
Aug 12, 2024
Member
|
Test failures are unrelated and are resolved elsewhere. I'm okay with this change for now. Adding typing for |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #7078
Users who run their own code in Mypy strict mode require that all calls they make are to typed interfaces.
I did initially explore the possibility of annotating these
**paramsasUnpack[TypedDict](see PEP 692) but it was not readily apparent from the source code what all the possibilities were, and until PEP 728 is accepted this had the potential to break perfectly valid code that were using parameters that I did not anticipate. So I dropped this idea pretty quickly.But to solve the basic issue in user code, all this needs is an annotation - of any kind. So I went ahead and added an
Any.Here is some sample code, run on Mypy strict:
Before:
After:
@MarcSkovMadsen