8000 Auth: guard against user being removed by maximlt · Pull Request #6908 · holoviz/panel · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@maximlt
Copy link
Member
@maximlt maximlt commented Jun 10, 2024

A user reported sometimes getting a KeyError at line 1008 in auth.py.

@maximlt maximlt requested a review from philippjfr June 10, 2024 09:50
@codecov
Copy link
codecov bot commented Jun 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.54%. Comparing base (681ddc9) to head (0d6440f).
Report is 4 commits behind head on main.

Files Patch % Lines
panel/auth.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6908       +/-   ##
===========================================
+ Coverage   38.42%   81.54%   +43.12%     
===========================================
  Files         308      319       +11     
  Lines       45062    46915     +1853     
===========================================
+ Hits        17315    38259    +20944     
+ Misses      27747     8656    -19091     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit d7adb40 into main Jun 12, 2024
@philippjfr philippjfr deleted the fix_oauth_keyerror branch June 12, 2024 08:58
maximlt added a commit that referenced this pull request Jun 12, 2024
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0