Fix card header margins #6639
Merged
Fix card header margins #6639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
563ded1 to
c9be2bc
Compare
Member
|
Merging despite the failures as I'm resolving those in #6641 |
philippjfr
approved these changes
Apr 2, 2024
Member
There was a problem hiding this comment.
I would have accepted one change for the chevrons and the margins but duplicating them like you have done here is a bit confusing.
Member
|
Really appreciate these changes btw, I've been planning to do this for a long time. |
Contributor
Author
|
Ooh yeah, I forgot to change branch before starting on the margin, but I appreciate the merge! |
ahuang11
added a commit
that referenced
this pull request
Apr 2, 2024
ahuang11
added a commit
that referenced
this pull request
Apr 2, 2024
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The card header CSS seemed to be all over the place and imbalanced; this PR tries to make it less complex and have a balanced margin/padding.
Before (notice the left has a bit more padding vs the right):
After:
