8000 Add scale animation to icon on hover and active class by ahuang11 · Pull Request #6376 · holoviz/panel · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@ahuang11
Copy link
Contributor
@ahuang11 ahuang11 commented Feb 22, 2024
Screen.Recording.2024-02-22.at.12.29.31.PM.mov

@ahuang11 ahuang11 changed the title Add ease to icon Add scale animation to icon on hover Feb 22, 2024
@ahuang11 ahuang11 requested a review from philippjfr February 22, 2024 19:42
@codecov
Copy link
codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.62%. Comparing base (ebe8d66) to head (ee4dfc4).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6376      +/-   ##
==========================================
+ Coverage   83.61%   83.62%   +0.01%     
==========================================
  Files         305      305              
  Lines       45588    45594       +6     
==========================================
+ Hits        38120    38130      +10     
+ Misses       7468     7464       -4     
Flag Coverage Δ
ui-tests 39.66% <100.00%> (+0.01%) ⬆️
unitexamples-tests 71.61% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ahuang11 ahuang11 changed the title Add scale animation to icon on hover Add scale animation to icon on hover and active class Feb 22, 2024
@philippjfr
Copy link
Member

Failing test, otherwise this looks fine.

@philippjfr philippjfr merged commit f01fe1f into main Feb 24, 2024
@philippjfr philippjfr deleted the add_ease_animation_icon branch February 24, 2024 10:59
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0