Add HoloViz logos as ChatMessage avatars #6348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes it more convenient
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6348 +/- ##
===========================================
- Coverage 82.92% 40.27% -42.66%
===========================================
Files 313 313
Lines 45834 45842 +8
===========================================
- Hits 38007 18462 -19545
- Misses 7827 27380 +19553
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Collaborator
There was a problem hiding this comment.
Should all the avatars not be available from cdn?
- we are in control
- loads faster?
Contributor
Author
|
That sounds good to me; I don't have experience uploading to CDN / using CDN resources though. Is it documented somewhere? |
philippjfr
reviewed
Feb 15, 2024
Contributor
Author
|
philippjfr
reviewed
Feb 16, 2024
philippjfr
reviewed
Feb 16, 2024
philippjfr
reviewed
Feb 20, 2024
philippjfr
reviewed
Feb 21, 2024
philippjfr
approved these changes
Mar 16, 2024
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it more convenient to just use
user="hvplot"oruser="lumen"without manually setting avatar.