8000 Don't pop ChatInterface variables by hoxbro · Pull Request #6290 · holoviz/panel · GitHub
[go: up one dir, main page]
Skip to content

Don't pop ChatInterface variables #6290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hoxbro merged 5 commits into from
Feb 1, 2024
Merged

Don't pop ChatInterface variables #6290

hoxbro merged 5 commits into from
Feb 1, 2024

Conversation

@hoxbro
Copy link
Member
@hoxbro hoxbro commented Jan 31, 2024 •
edited
Loading

Without these changes, ChatInterface will not use the new username.

import panel as pn
pn.extension()

pn.chat.ChatInterface(callback=lambda _0, user, _2: user, user="NEW USERNAME")

image

@codecov
Copy link
codecov bot commented Jan 31, 2024 •
edited
Loading

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (811ccd1) 40.72% compared to head (ad3c846) 84.19%.
Report is 3 commits behind head on main.

Files Patch % Lines
panel/chat/interface.py 88.88% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #6290       +/-   ##
===========================================
+ Coverage   40.72%   84.19%   +43.47%     
===========================================
  Files         301      301               
  Lines       45219    45247       +28     
===========================================
+ Hits        18414    38095    +19681     
+ Misses      26805     7152    -19653
Flag Coverage Δ
ui-tests 40.71% <18.75%> (-0.01%) ⬇️
unitexamples-tests 71.84% <93.75%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
8000

@hoxbro hoxbro marked this pull request as ready for review January 31, 2024 16:15
philippjfr
philippjfr reviewed Jan 31, 2024
View reviewed changes
philippjfr
philippjfr reviewed Jan 31, 2024
View reviewed changes
Copy link
Member
@philippjfr philippjfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahuang11 please review.

ahuang11
ahuang11 reviewed Jan 31, 2024
View reviewed changes
ahuang11
ahuang11 approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor
@ahuang11 ahuang11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@hoxbro @ahuang11
Update panel/tests/chat/test_interface.py
715311d 
Co-authored-by: Andrew <15331990+ahuang11@users.noreply.github.com>
@hoxbro
Copy link
Member Author
hoxbro commented Jan 31, 2024

Looking at the failing test and a bit at the code. I think there are some possibilities:

  1. We promote the parameters user and avatar from Interface to Feed.
  2. Inherit send and stream (I think) in Interface and check if they are not set as a keyword argument, set them to the parameter if they haven't been set, and then call super.
  3. Update the if statement so we both have them as parameters and in the message kwargs.
  4. Maybe another way forward.

I think I like 2 the most.

@ahuang11
Copy link
Contributor
ahuang11 commented Jan 31, 2024

I like 2 too.

@hoxbro hoxbro force-pushed the chatinterface_user branch from 7b31ba5 to ad3c846 Compare January 31, 2024 20:17
@hoxbro hoxbro merged commit 355a38b into main Feb 1, 2024
@hoxbro hoxbro deleted the chatinterface_user branch February 1, 2024 08:00
@philippjfr philippjfr mentioned this pull request Mar 20, 2024
Merged
@github-actions
Copy link
github-actions bot commented Sep 10, 2025

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@philippjfr philippjfr philippjfr left review comments

@ahuang11 ahuang11 ahuang11 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hoxbro @ahuang11 @philippjfr
0