Fix logic when looking up pn.state.curdoc #6254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6254 +/- ##
==========================================
- Coverage 84.20% 84.19% -0.01%
==========================================
Files 301 301
Lines 45157 45190 +33
==========================================
+ Hits 38023 38047 +24
- Misses 7134 7143 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #5952 we refactored the
try/finallyblock ofpn.state.curdoc. However in doing so we didn't take into account that thefinallyblock is always processed last and any value returned in the finally block takes precedence. We now refactor this block correctly to ensure that we always look up thecurdocin theContextVarfirst ensuring that async callbacks return the correctcurdoc.Fixes #6252