More complete patch for the TextEditor to support being rendered in the Shadow DOM #6222
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6222 +/- ##
===========================================
+ Coverage 22.35% 84.18% +61.83%
===========================================
Files 299 301 +2
Lines 44647 45099 +452
===========================================
+ Hits 9980 37967 +27987
+ Misses 34667 7132 -27535
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Looks good, thanks! One nitpick, please use the standard of 2-space indentation that we use for all TS code.
Done in cb89e1a using the built-in formatter in VSCode. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
In a complex application using the TextEditor widget it becomes unusable after certain operations. I couldn't reproduce the bug with a simple example. I found a Shadow DOM patch (slab/quill#2961 (comment)) that looked more complete and that made other Quill users happy, so I decided to try it out. It seems like it fixed my issue! I've updated a test as it fixes another issue (see the last paragraph of this comment #5511 (comment)).