Fix generator placeholder and optimize updates #6105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6105 +/- ##
==========================================
- Coverage 84.67% 84.65% -0.02%
==========================================
Files 296 296
Lines 44100 44105 +5
==========================================
- Hits 37341 37338 -3
- Misses 6759 6767 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
philippjfr
approved these changes
Jan 9, 2024
philippjfr
pushed a commit
that referenced
this pull request
Jan 17, 2024
This was referenced Jan 17, 2024
Merged
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In generator tasks, the condition
while not task.done() and num_entries == len(self._chat_log):leads to tasks completing almost instantly, as generators are lazily evaluated. Consequently, relying ontask.done()becomes unreliable.When using
submit_task(generator), thestate.FiNISHEDis quickly reached because, technically, the generator is lazily evaluated and returned. To illustrate, the generator is considered "finished" in a mere 1.33 microseconds, as depicted in the image below:So it's not reliable to depend on
task.done()Instead, we should usecallback_state.IDLEto track business (when re-reading this, I was confused and realized, business -> busy-ness)Also, this updates how the placeholder text gets updated.
Addresses
https://discourse.holoviz.org/t/spinning-icon-effect-that-appears-when-the-user-sends-a-message-in-chatinterface/6582/10?u=ahuang11