8000 Fix fast FileDownload embed=True style by MarcSkovMadsen · Pull Request #5875 · holoviz/panel · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@MarcSkovMadsen
Copy link
Collaborator
@MarcSkovMadsen MarcSkovMadsen commented Nov 15, 2023

Closes #5874

The example from the issue looks like

image

@codecov
Copy link
codecov bot commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (51adf14) 72.36% compared to head (d01368c) 83.93%.
Report is 15 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5875       +/-   ##
===========================================
+ Coverage   72.36%   83.93%   +11.57%     
===========================================
  Files         290      290               
  Lines       42236    42391      +155     
===========================================
+ Hits        30562    35580     +5018     
+ Misses      11674     6811     -4863     
Flag Coverage Δ
ui-tests 40.89% <ø> (?)
unitexamples-tests 72.27% <ø> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MarcSkovMadsen
Copy link
Collaborator Author

The failing tests are ui tests of the chat interface that time out. I don't think its related.

@hoxbro
Copy link
Member
hoxbro commented Nov 15, 2023

The failing tests are ui tests of the chat interface that time out. I don't think its related.

It is unrelated, but the tests are in the unit test, not the UI test. I thought I fixed these yesterday. There could be a more underlying issue with the chat components. But all of this has nothing to do with this PR. @ahuang11, can you look at why the chat tests are flaky and open a new issue / PR with your findings?

@philippjfr philippjfr merged commit 5425c20 into main Nov 15, 2023
@philippjfr philippjfr deleted the fix/download-button-embed branch November 15, 2023 11:58
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FileDownloadButton with embed=True not styled

3 participants

0