8000 Speed up config.__getattr__ with a factor 10 corresponding to 5-10% app speed up. by MarcSkovMadsen · Pull Request #5851 · holoviz/panel · GitHub
[go: up one dir, main page]
Skip to content

Speed up config.__getattr__ with a factor 10 corresponding to 5-10% app speed up. #5851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
philippjfr merged 11 commits into from
Nov 12, 2023
Merged

Speed up config.__getattr__ with a factor 10 corresponding to 5-10% app speed up. #5851

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
15c4d15
fix-config-performance
MarcSkovMadsen Nov 11, 2023
4dd7e93
fix
MarcSkovMadsen Nov 11, 2023
a4491c7
fix
MarcSkovMadsen Nov 11, 2023
ece3e8a
improve
MarcSkovMadsen Nov 11, 2023
35767a6
clean up
MarcSkovMadsen Nov 11, 2023
e24dc69
Small cleanup
philippjfr Nov 11, 2023
3d80790
Make admin a global config option
philippjfr Nov 11, 2023
18e9210
Use optimized parameter set where possible
philippjfr Nov 11, 2023
cb9fed7
One more change to globals lookup
philippjfr Nov 11, 2023
fab0490
Fix variable
philippjfr Nov 11, 2023
02d6795
Compute _config parameters once
philippjfr Nov 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
improve
  • Loading branch information
@MarcSkovMadsen
MarcSkovMadsen committed Nov 11, 2023
commit ece3e8a714f85546a5403dbfccc3da31c197cefb
12 changes: 9 additions & 3 deletions panel/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@
from collections import defaultdict

ATTRS = defaultdict(lambda: 0)
_PARAMS = None

def validate_config(config, parameter, value):
"""
Expand Down Expand Up @@ -450,10 +451,15 @@ def __getattribute__(self, attr):
if attr=="param":
return super().__getattribute__(attr)

global _PARAMS
if not _PARAMS and init:
_PARAMS = set(super().__getattribute__('param'))

if init and not attr.startswith('__'):
params = set(super().__getattribute__('param'))
_params=_PARAMS
else:
params = []
_params = {}

session_config = super().__getattribute__('_session_config')
curdoc = state.curdoc
if curdoc and curdoc not in session_config:
Expand All @@ -466,7 +472,7 @@ def __getattribute__(self, attr):
return super().__getattribute__(attr)
elif curdoc and curdoc in session_config and attr in session_config[curdoc]:
return session_config[curdoc][attr]
elif f'_{attr}' in params and getattr(self, f'_{attr}_') is not None:
elif f'_{attr}' in _params and getattr(self, f'_{attr}_') is not None:
return super().__getattribute__(f'_{attr}_')
return super().__getattribute__(attr)

Expand Down
0