Fix patching a table with a DataFrame with a custom index #5645
Conversation
Codecov Report
@@ Coverage Diff @@
## main #5645 +/- ##
==========================================
- Coverage 83.65% 83.60% -0.05%
==========================================
Files 280 280
Lines 41580 41635 +55
==========================================
+ Hits 34782 34811 +29
- Misses 6798 6824 +26
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 7 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
The examples tests are failing on the import pandas as pd
import panel as pn
pn.extension()
df = pd.DataFrame({'int': [1, 2, 3], 'float': [3.14, 6.28, 9.42], 'str': ['A', 'B', 'C'], 'bool': [True, False, True]}, index=[1, 2, 3])
table = pn.widgets.DataFrame(df)
table.patch({
'bool': [
(0, False),
(2, False)
],
'int': [
(slice(0, 2), [3, 2])
]
})Note that the index of the DataFrame is The default of |
There was a problem hiding this comment.
This looks great, thank you for adding the tests!
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Fixes #5554