Allow configuring the logout page #5514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #5514 +/- ##
===========================================
+ Coverage 72.50% 83.61% +11.10%
===========================================
Files 276 276
Lines 40199 40233 +34
===========================================
+ Hits 29147 33641 +4494
+ Misses 11052 6592 -4460
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 66 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
philippjfr
commented
Sep 15, 2023
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of immediately directing a user back to the login page this PR ensures that the
/logoutendpoint serves a page that confirms logging out and allows the user to click a button to log back in. It also makes this template configurable and adds documentation.Additionally this PR fixes some issues with redirects, particularly when a prefix is provided.
Fixes #5492