8000 Add disconnect warning to Notification by philippjfr · Pull Request #5244 · holoviz/panel · GitHub
[go: up one dir, main page]
Skip to content

Add disconnect warning to Notification #5244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
philippjfr merged 8 commits into from
Jul 14, 2023
Merged

Add disconnect warning to Notification #5244

philippjfr merged 8 commits into from
Jul 14, 2023

Conversation

@philippjfr
Copy link
Member
@philippjfr philippjfr commented Jul 11, 2023 •
edited
Loading

This PR enables a warning via the notification area that informs the user when the Websocket connection is dropped. The warning is enabled by default when the pn.config.notifications = True and the warning message can be configured.

Fix for #5240

  • Add test
  • Add documentation

@codecov
Copy link
codecov bot commented Jul 11, 2023 •
edited
Loading

Codecov Report

Merging #5244 (08ba4ee) into main (f2cefe3) will decrease coverage by 0.11%.
The diff coverage is 62.50%.

@@            Coverage Diff             @@
##             main    #5244      +/-   ##
==========================================
- Coverage   83.83%   83.72%   -0.11%     
==========================================
  Files         274      274              
  Lines       39606    39637      +31     
==========================================
- Hits        33203    33186      -17     
- Misses       6403     6451      +48
Flag Coverage Δ
ui-tests 40.37% <44.64%> (-0.19%) ⬇️
unitexamples-tests 73.64% <41.07%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/io/admin.py 0.00% <0.00%> (ø)
panel/io/state.py 71.59% <0.00%> (-1.87%) ⬇️
panel/viewable.py 65.78% <0.00%> (ø)
panel/tests/ui/io/test_notifications.py 79.66% <71.42%> (-4.55%) ⬇️
panel/io/notifications.py 64.89% <75.00%> (+0.44%) ⬆️
panel/config.py 76.84% <78.57%> (-0.10%) ⬇️
panel/tests/test_server.py 99.34% <100.00%> (+<0.01%) ⬆️

... and 18 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

hoxbro
hoxbro reviewed Jul 11, 2023
View reviewed changes
@philippjfr philippjfr force-pushed the disconnect_warning branch from 42e1f03 to 7e1c921 Compare July 14, 2023 14:02
@philippjfr philippjfr merged commit 99ad77f into main Jul 14, 2023
@philippjfr philippjfr deleted the disconnect_warning branch July 14, 2023 16:59
@philippjfr philippjfr mentioned this pull request Jul 18, 2023
Merged
@maximlt maximlt mentioned this pull request Jul 19, 2023
Merged
@github-actions
Copy link
github-actions bot commented Sep 10, 2025

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@hoxbro hoxbro hoxbro left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@philippjfr @hoxbro
0