8000 Update Tabulator version and improve visibility handling by philippjfr · Pull Request #5182 · holoviz/panel · GitHub 8000
[go: up one dir, main page]

Skip to content

Conversation

@philippjfr
Copy link
Member
  • Update to Tabulator 5.5.0
  • Implement handling for visible property
  • Do not render table until CSS is fully loaded
  • Card sets visible property of collapsed components

@codecov
Copy link
codecov bot commented Jun 29, 2023

Codecov Report

Merging #5182 (e33536a) into main (4139d54) will decrease coverage by 10.01%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##             main    #5182       +/-   ##
===========================================
- Coverage   83.78%   73.78%   -10.01%     
===========================================
  Files         274      274               
  Lines       39524    39575       +51     
===========================================
- Hits        33115    29200     -3915     
- Misses       6409    10375     +3966     
Flag Coverage Δ
ui-tests ?
unitexamples-tests 73.78% <100.00%> (+0. 8000 03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/tests/io/test_resources.py 99.00% <ø> (ø)
panel/models/tabulator.py 97.53% <100.00%> (ø)

... and 60 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr
Copy link
Member Author

Sadly updating tabulator breaks the convert resources causing the UI tests to fail. I'll have to cut a new dev release to resolve that.

@philippjfr philippjfr merged commit 2d6e24f into main Jun 29, 2023
@philippjfr philippjfr deleted the tabulator_upgrade branch June 29, 2023 15:00
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

< 7DDA input type="hidden" name="_method" value="put" autocomplete="off" />

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0