8000 Remove duplicated helper function for Vega selections by philippjfr · Pull Request #5164 · holoviz/panel · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@philippjfr
Copy link
Member

Follow up to #5145

Accidentally left in the old version of the _get_type function.

@codecov
Copy link
codecov bot commented Jun 22, 2023

Codecov Report

Merging #5164 (41e2ac7) into main (0fc20f3) will increase coverage by 0.19%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5164      +/-   ##
==========================================
+ Coverage   83.59%   83.79%   +0.19%     
==========================================
  Files         274      274              
  Lines       39498    39490       -8     
==========================================
+ Hits        33020    33090      +70     
+ Misses       6478     6400      -78     
Flag Coverage Δ
ui-tests 40.57% <ø> (+1.04%) ⬆️
unitexamples-tests 73.71% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/pane/vega.py 82.10% <ø> (+3.31%) ⬆️

... and 10 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit ec49c2d into main Jun 22, 2023
@philippjfr philippjfr deleted the vega_sel_fix branch June 22, 2023 15:20
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0