8000 Ensure Tabulator internal _index_mapping is updated on stream by philippjfr · Pull Request #4292 · holoviz/panel · GitHub
[go: up one dir, main page]
Skip to content

Ensure Tabulator internal _index_mapping is updated on stream #4292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
philippjfr merged 1 commit into from
Jan 16, 2023
Merged

Ensure Tabulator internal _index_mapping is updated on stream #4292

philippjfr merged 1 commit into from
Jan 16, 2023
8000

Conversation

@philippjfr
Copy link
Member
@philippjfr philippjfr commented Jan 16, 2023

Fixes issues editing newly streamed rows on Tabulator

@philippjfr philippjfr added type: bug component: tabulator Related to the Tabulator widget labels Jan 16, 2023
@philippjfr philippjfr added this to the v0.14.3 milestone Jan 16, 2023
@codecov
Copy link
codecov bot commented Jan 16, 2023 •
edited
Loading

Codecov Report

Merging #4292 (ff4e883) into main (ef28443) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #4292   +/-   ##
=======================================
  Coverage   82.68%   82.69%           
=======================================
  Files         239      239           
  Lines       34424    34464   +40     
=======================================
+ Hits        28465    28501   +36     
- Misses       5959     5963    +4
Flag Coverage Δ
ui-tests 38.07% <63.63%> (+0.06%) ⬆️
unitexamples-tests 73.79% <52.27%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/tests/ui/widgets/test_tabulator.py 98.83% <100.00%> (-0.15%) ⬇️
panel/tests/widgets/test_tables.py 99.67% <100.00%> (+<0.01%) ⬆️
panel/widgets/tables.py 88.27% <100.00%> (+0.13%) ⬆️
panel/tests/util.py 89.32% <0.00%> (-1.95%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit 9388d39 into main Jan 16, 2023
@philippjfr philippjfr deleted the update_index_mapping branch January 16, 2023 18:00
philippjfr added a commit that referenced this pull request Jan 16, 2023
@philippjfr
Ensure Tabulator internal _index_mapping is updated on stream (#4292)
64b6297
@philippjfr philippjfr mentioned this pull request Jan 27, 2023
Merged
@github-actions
Copy link
github-actions bot commented Sep 11, 2025

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

component: tabulator Related to the Tabulator widget

Projects

None yet

Milestone

v0.14.3

Development

Successfully merging this pull request may close these issues.

2 participants

@philippjfr
0