8000 Support non-vtkPolyData types in vtk synchronizer by banesullivan · Pull Request #4124 · holoviz/panel · GitHub
[go: up one dir, main page]
Skip to content

Support non-vtkPolyData types in vtk synchronizer #4124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
philippjfr merged 1 commit into from
Nov 16, 2022
Merged

Support non-vtkPolyData types in vtk synchronizer #4124

philippjfr merged 1 commit into from
Nov 16, 2022

Conversation

@banesullivan
Copy link
Contributor
@banesullivan banesullivan commented Nov 15, 2022

I think this is all that is needed to support all non-vtkPolyData types to resolve pyvista/pyvista#3576

I edited this online and did not test/verify. I'm sure there are edge cases but this should generally improve support for more data types

cc @k-a-mendoza

@codecov
Copy link
codecov bot commented Nov 15, 2022 •
edited
Loading

Codecov Report

Merging #4124 (6260928) into master (da1a717) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4124      +/-   ##
==========================================
- Coverage   83.50%   83.44%   -0.06%     
==========================================
  Files         223      223              
  Lines       33317    33317              
==========================================
- Hits        27820    27802      -18     
- Misses       5497     5515      +18
Flag Coverage Δ
ui-tests 37.58% <0.00%> (+0.07%) ⬆️
unitexamples-tests 74.14% <100.00%> (-0.46%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/pane/vtk/synchronizable_serializer.py 77.67% <100.00%> (ø)
panel/models/quill.py 71.42% <0.00%> (-14.29%) ⬇️
panel/models/echarts.py 76.47% <0.00%> (-11.77%) ⬇️
panel/models/terminal.py 81.25% <0.00%> (-9.38%) ⬇️
panel/models/jsoneditor.py 75.00% <0.00%> (-9.38%) ⬇️
panel/tests/template/test_vanilla_manual.py 78.26% <0.00%> (-8.70%) ⬇️
panel/models/ace.py 83.33% <0.00%> (-8.34%) ⬇️
panel/tests/template/test_manual.py 57.57% <0.00%> (-4.05%) ⬇️
panel/tests/command/test_serve.py 81.70% <0.00%> (-3.66%) ⬇️
panel/tests/widgets/test_speech_to_text.py 88.65% <0.00%> (-2.07%) ⬇️
... and 12 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr
Copy link
Member
philippjfr commented Nov 15, 2022

Looks good. At some point I'd like to work with you to split out panel-vtk and get some better testing set up.

@philippjfr
Copy link
Member
philippjfr commented Nov 15, 2022

And working with you can just mean I ask you a bunch of questions 😄

@banesullivan
Copy link
Contributor Author
banesullivan commented Nov 15, 2022

Happy to help!! There is much to be done to centralize/bring together all of the fantastic work done across VTK, PyVista, panel, trame, and others to solve much of the same problems with this bi-directional synchronization of a vtkRenderWindow. Im actually working on this right now... so feel free to ask questions when you get around to splitting up panel-vtk so we can build on some common code

philippjfr
philippjfr approved these changes Nov 16, 2022
View reviewed changes
Copy link
Member
@philippjfr philippjfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simply enough change, looks good!

@philippjfr philippjfr merged commit 544af6d into holoviz:master Nov 16, 2022
@banesullivan banesullivan mentioned this pull request Dec 6, 2022
Closed
@github-actions
Copy link
github-actions bot commented Sep 11, 2025

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@philippjfr philippjfr philippjfr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AttributeError: 'ExplicitStructuredGrid' object has no attribute 'GetVerts'

2 participants

@banesullivan @philippjfr
0