8000 Simplify implementation of state.curdoc by philippjfr · Pull Request #3834 · holoviz/panel · GitHub
[go: up one dir, main page]
Skip to content

Simplify implementation of state.curdoc #3834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
philippjfr merged 3 commits into from
Sep 14, 2022
Merged

Simplify implementation of state.curdoc #3834

philippjfr merged 3 commits into from
Sep 14, 2022

Conversation

@philippjfr
Copy link
Member
@philippjfr philippjfr commented Sep 14, 2022

So I hadn't realized contextvars.ContextVar was available in Python 3.7 when I wrote the state.curdoc management code. This implementation is much cleaner.

@codecov
Copy link
codecov bot commented Sep 14, 2022 •
edited
Loading

Codecov Report

Merging #3834 (6a4333b) into master (3a2103b) will decrease coverage by 7.62%.
The diff coverage is 66.66%.

❗ Current head 6a4333b differs from pull request most recent head 1188df4. Consider uploading reports for the commit 1188df4 to get more accurate results

@@            Coverage Diff             @@
##           master    #3834      +/-   ##
==========================================
- Coverage   82.89%   75.26%   -7.63%     
==========================================
  Files         222      222              
  Lines       32459    32381      -78     
==========================================
- Hits        26908    24373    -2535     
- Misses       5551     8008    +2457
Flag Coverage Δ
ui-tests ?
unite 8000 xamples-tests 75.26% <66.66%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/io/jupyter_server_extension.py 0.00% <0.00%> (ø)
panel/io/pyodide.py 0.00% <0.00%> (ø)
panel/io/server.py 74.75% <ø> (-0.20%) ⬇️
panel/tests/conftest.py 80.53% <ø> (-7.68%) ⬇️
panel/io/state.py 68.91% <85.71%> (-2.21%) ⬇️
panel/tests/ui/widgets/test_tabulator.py 9.82% <0.00%> (-89.07%) ⬇️
panel/tests/ui/widgets/test_input.py 11.33% <0.00%> (-88.09%) ⬇️
panel/tests/ui/layout/test_accordion.py 14.72% <0.00%> (-85.28%) ⬇️
panel/tests/ui/widgets/test_sliders.py 15.42% <0.00%> (-84.58%) ⬇️
panel/tests/ui/layout/test_card.py 18.01% <0.00%> (-81.99%) ⬇️
... and 26 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit 3a7a791 into master Sep 14, 2022
@philippjfr philippjfr deleted the context_var_curdoc branch September 14, 2022 17:10
@github-actions
Copy link
github-actions bot commented Sep 11, 2025

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@philippjfr
0