8000 Vtk/vtk improvements by xavArtley · Pull Request #2826 · holoviz/panel · GitHub
[go: up one dir, main page]
Skip to content

Vtk/vtk improvements #2826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
philippjfr merged 5 commits into from
Oct 15, 2021
Merged

Vtk/vtk improvements #2826

philippjfr merged 5 commits into from
Oct 15, 2021

Conversation

@xavArtley
Copy link
Collaborator
@xavArtley xavArtley commented Oct 15, 2021

I need to use VTK panel at work so in the same time I had some small enhancements

Now nans are handle for VTKVolumes and nan_opacity in slices can be set
nan_opacity

I updated model with the new bokeh syntax in static init

@xavArtley xavArtley added type: enhancement Minor feature or improvement to an existing feature status: WIP labels Oct 15, 2021
@codecov
Copy link
codecov bot commented Oct 15, 2021 •
edited
Loading

Codecov Report

Merging #2826 (48aed06) into master (0773b0d) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2826      +/-   ##
==========================================
- Coverage   83.06%   83.05%   -0.02%     
==========================================
  Files         188      188              
  Lines       24305    24419     +114     
==========================================
+ Hits        20188    20280      +92     
- Misses       4117     4139      +22
Impacted Files Coverage Δ
panel/models/vtk.py 98.50% <100.00%> (+0.02%) ⬆️
panel/pane/vtk/vtk.py 97.07% <100.00%> (+<0.01%) ⬆️
panel/widgets/tables.py 85.14% <0.00%> (-1.42%) ⬇️
panel/widgets/select.py 93.82% <0.00%> (+0.01%) ⬆️
panel/tests/widgets/test_tables.py 99.43% <0.00%> (+0.03%) ⬆️
panel/models/tabulator.py 94.52% <0.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0773b0d...48aed06. Read the comment docs.

philippjfr
philippjfr reviewed Oct 15, 2021
View reviewed changes
@philippjfr
Copy link
Member
philippjfr commented Oct 15, 2021

Ready to merge?

@philippjfr
Copy link
Member
philippjfr commented Oct 15, 2021

Oh if you get a chance document the parameter in the reference gallery.

@philippjfr philippjfr merged commit b0d9b5a into master Oct 15, 2021
@philippjfr philippjfr deleted the vtk/vtk_improvements branch October 15, 2021 15:42
@github-actions
Copy link
github-actions bot commented Sep 11, 2025

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Assignees

No one assigned

Labels

status: ready type: enhancement Minor feature or improvement to an existing feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xavArtley @philippjfr
0