8000 added togglegroup docs [ci disable examples] by Stubatiger · Pull Request #2679 · holoviz/panel · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@Stubatiger
Copy link
Contributor
@Stubatiger Stubatiger commented Aug 27, 2021

Added description for the ToggleGroup widget as mentioned in #2674

@philippjfr
Copy link
Member

Thanks @Stubatiger. Before I merge could you make sure you clear the notebook?

@Stubatiger
Copy link
Contributor Author

Is there a specific way to clean it? Normally i just do the "Restart kernel and clear all outputs" in the jupyter lab interface

@philippjfr
Copy link
Member

That would already be sufficient so please do that and then update the PR. We additionally clear the metadata from the notebooks using this little script:

#!/bin/bash
jq --indent 1 \
    '
    (.cells[] | select(has("outputs")) | .outputs) = []
    | (.cells[] | select(has("execution_count")) | .execution_count) = null
    | .metadata = {"language_info": {"name":"python", "pygments_lexer": "ipython3"}}
    | .cells[].metadata = {}
    ' $1 > /tmp/stripped.ipynb

but I usually run that before releases so I don't hold up merging contributor PRs.

@codecov
Copy link
codecov bot commented Sep 2, 2021

Codecov Report

Merging #2679 (79df868) into master (67d6492) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2679      +/-   ##
==========================================
- Coverage   81.98%   81.98%   -0.01%     
==========================================
  Files         187      187              
  Lines       23948    23948              
==========================================
- Hits        19634    19633       -1     
- Misses       4314     4315       +1     
Impacted Files Coverage Δ
panel/tests/pane/test_plotly.py 98.10% <0.00%> (-0.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67d6492...79df868. Read the comment docs.

@Stubatiger
Copy link
Contributor Author

That would already be sufficient so please do that and then update the PR. W

Thought i already did that, cleaned it up now

@philippjfr philippjfr merged commit 5c35621 into holoviz:master Sep 16, 2021
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0