Golden layout improvements #1419
Conversation
…t and dark themes into corresponding css themes to get around issues with importing the css files and using links in html
|
I'm not really following your description here, but looking at the changes everything looks correct and as I would expect. Could you clarify what you mean by "stratify which element was used for the built in Golden Layout light and dark themes by whether DarkTheme or DefaultTheme were set , and when I attempted to use an import in the respective css files the styling came out wrong and drastically different."? |
|
@philippjfr I actually got the css imports working, I'm not sure what the issue was before but I'll have a new commit reflecting it soon. |
|
Can you explain how this PR relates to #1395? Does it supersede it? Should the other one be closed? |
|
@philippjfr This does supersede #1395, I'll go close that PR. |
|
@philippjfr I made some updates to the html and styling to fix some border issues and restrict the width of the sidebar, as well as making the panel items fit within the tabs. Let me know if this looks correct to you. |
…er issues and smooth out panel item widths
Codecov Report
@@ Coverage Diff @@
## master #1419 +/- ##
==========================================
- Coverage 87.78% 87.75% -0.03%
==========================================
Files 135 136 +1
Lines 14930 14961 +31
==========================================
+ Hits 13106 13129 +23
- Misses 1824 1832 +8
Continue to review full report at Codecov.
|
|
Thanks, I'm pretty swamped but will try to review tomorrow. |
|
This template will be amazing. 👍 |
|
Thanks @kebowen730! After a bit more cleanup and improvements to the resizing behavior this is working pretty well. |
* attempting to nmove the sidebar content into a movable tab * updating the sidebar to be a golden layout component * solving an issue with golden layout by copying the golden layout light and dark themes into corresponding css themes to get around issues with importing the css files and using links in html * fixing golden layout style sheet imports * adding GoldenTemplate to the template __init__.py file * removing unneeded imports * updating golden template styling to restrict sidebar sizing, fix border issues and smooth out panel item widths * Cleanup and layout improvements * Improved resizing behavior * Fixed flakes * Label Golden Layout tabs Co-authored-by: Philipp Rudiger <prudiger@anaconda.com>
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
I've attached screenshots of what the Golden Layout template looks like currently for feedback on the styling.
Starting with Phillip's initial template, I removed the original sidebar element and converted it into a Golden Layout Component. From there, I added styling and ran into an issue where I couldn't find a way to stratify which element was used for the built in Golden Layout light and dark themes by whether DarkTheme or DefaultTheme were set, and when I attempted to use an import in the respective css files the styling came out wrong and drastically different. Since the styling needs with golden layout were fairly complex, the solution I decided on was somewhat of a brute force approach where I copied the the contents of the built in stylesheets and copied them into the corresponding css files.
My solution works, but does anyone have an idea of a smoother way to handle that problem?