Fix bug in closed Tabs handling #1337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1337 +/- ##
==========================================
- Coverage 87.71% 87.69% -0.03%
==========================================
Files 126 126
Lines 13583 13590 +7
==========================================
+ Hits 11915 11918 +3
- Misses 1668 1672 +4
Continue to review full report at Codecov.
|
philippjfr
added a commit
that referenced
this pull request
May 24, 2020
* Fix bug in closed Tabs handling * Fixed flake
philippjfr
added a commit
that referenced
this pull request
Jun 19, 2020
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The server seemingly sometimes sends messages that are misinterpreted as Tab close events, this ensures these events are ignored.