E533 Compatibility with Bokeh 2 DatePicker by hyamanieu · Pull Request #1187 · holoviz/panel · GitHub
[go: up one dir, main page]
Skip to content

Compatibility with Bokeh 2 DatePicker #1187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
philippjfr merged 3 commits into from
Mar 25, 2020
Merged

Compatibility with Bokeh 2 DatePicker #1187

philippjfr merged 3 commits into from
Mar 25, 2020

Conversation

@hyamanieu
Copy link
Collaborator
@hyamanieu hyamanieu commented Mar 25, 2020

See bokeh/bokeh#9509 , date is in ISO format.

@philippjfr
Copy link
Member
philippjfr commented Mar 25, 2020

Thanks, we'll also have to update the existing tests which mocks a change in the date but still uses the old date format

panel/panel/tests/widgets/test_input.py

Line 42 in ffcdd3c

date_picker._comm_change({'value': 'Mon Sep 03 2018'})

@hyamanieu hyamanieu mentioned this pull request Mar 25, 2020
Closed
@codecov
Copy link
codecov bot commented Mar 25, 2020

Codecov Report

Merging #1187 into master will not change coverage by %.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1187   +/-   ##
=======================================
  Coverage   87.79%   87.79%           
=======================================
  Files         105      105           
  Lines       12598    12598           
=======================================
  Hits        11061    11061           
  Misses       1537     1537
Impacted Files Coverage Δ
panel/tests/widgets/test_input.py 100.00% <100.00%> (ø)
panel/widgets/input.py 96.12% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8c0c20...122678f. Read the comment docs.

@philippjfr
Copy link
Member
philippjfr commented Mar 25, 2020

Thanks again! Hugely appreciated.

@philippjfr philippjfr merged commit 62c0f46 into holoviz:master Mar 25, 2020
@philippjfr philippjfr mentioned this pull request Mar 27, 2020
Closed
@philippjfr philippjfr added this to the v0.9.4 milestone Apr 1, 2020
@github-actions
Copy link
7CBE
github-actions bot commented Sep 12, 2025

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v0.9.4

Development

Successfully merging this pull request may close these issues.

2 participants

@hyamanieu @philippjfr
0