8000 fix(docs): fixed typo and incorrect git command by witch-factory · Pull Request #4250 · highlightjs/highlight.js · GitHub
[go: up one dir, main page]
Skip to content

fix(docs): fixed typo and incorrect git command #4250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 11, 2025
Merged

fix(docs): fixed typo and incorrect git command #4250

merged 1 commit into from
May 11, 2025

Conversation

witch-factory
Copy link
Contributor

Changes

  • Fix incorrect quote syntax in git commit example
  • Correct "simply" to "simplify" in the Future section

Checklist

  • Added markup tests, or they don't apply here because it's only a document fix
  • Updated the changelog at CHANGES.md

@joshgoebel
Copy link
Member

How is the quoting incorrect?

@witch-factory
Copy link
Contributor Author

Hi. The original command in the docs was `git commit -m'(chore) add CDN distributable``
Its commit message is opened by singlequote and closed by backtick so quotes are not adequately closed.
I fixed it and, sure we can use singlequote in commit command but I guess doublequote is more widely used in such command so I used doublequote.
If singlequote was the convention in highlight.js docs, I'm sorry for that.

@joshgoebel
Copy link
Member

Oh, it was so minute I missed it. Thanks!

@joshgoebel joshgoebel merged commit 99cb5cd into highlightjs:main May 11, 2025
19 checks passed
@github-actions GitHub Actions
Copy link

Build Size Report

Changes to minified artifacts in /build, after gzip compression.

3 files changed

Total change -4 B

View Changes
file base pr diff
es/core.min.js 8.19 KB 8.19 KB -1 B
es/highlight.min.js 8.19 KB 8.19 KB -1 B
highlight.min.js 8.23 KB 8.23 KB -2 B

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yang062 Yang062 Yang062 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@witch-factory @joshgoebel @Yang062
0