8000 Merge pull request #216 from ycherniavskyi/fix-odd-renderer-state-cha… · hicodeboy/flutter-webrtc@bc8dc67 · GitHub
[go: up one dir, main page]

Skip to content

Commit bc8dc67

Browse files
authored
Merge pull request flutter-webrtc#216 from ycherniavskyi/fix-odd-renderer-state-changed-handler-nulling
Use proper state lifecycle method for nulling renderer state changed handler
2 parents 0051af3 + 675a37b commit bc8dc67

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

lib/rtc_video_view.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -128,8 +128,8 @@ class _RTCVideoViewState extends State<RTCVideoView> {
128128
}
129129

130130
@override
131-
void deactivate() {
132-
super.deactivate();
131+
void dispose() {
132+
super.dispose();
133133
widget._renderer.onStateChanged = null;
134134
}
135135

lib/web/rtc_video_view.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -171,8 +171,8 @@ class _RTCVideoViewState extends State<RTCVideoView> {
171171
}
172172

173173
@override
174-
void deactivate() {
175-
super.deactivate();
174+
void dispose() {
175+
super.dispose();
176176
_renderer.onStateChanged = null;
177177
}
178178

0 commit comments

Comments
 (0)
0