Use proper state lifecycle method for nulling renderer state changed handler #216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…handler Currently used `deactivate` method can be called many times during a state lifecycle. (For example, it called several times during animation, which occurs when Scaffold with RTCVideoView is shown with regular route push animation.) Actually, subclasses should override `deactivate` method to clean up any links between this object and other elements in the tree (e.g. if you have provided an ancestor with a pointer to a descendant's RenderObject).
|
LGTM |
cloudwebrtc
added a commit
that referenced
this pull request
Jul 4, 2020
…nged-handler-nulling Use proper state lifecycle method for nulling renderer state changed handler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a bat
3121
ch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently used deactivate method can be called many times during a state lifecycle.
(For example, it called several times during animation, which occurs when
ScaffoldwithRTCVideoViewis shown with regular route push animation.)Actually, subclasses should override
deactivatemethod to clean up any links betweenthis object and other elements in the tree (e.g. if you have provided an ancestor with
a pointer to a descendant's RenderObject). / adapted quote from State objects lifecycle