8000 HV-1831 Optimize cascading validation for large lists by marko-bekhta · Pull Request #1331 · hibernate/hibernate-validator · GitHub
[go: up one dir, main page]

Skip to content

HV-1831 Optimize cascading validation for large lists #1331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

marko-bekhta
Copy link
Member
@marko-bekhta marko-bekhta commented Sep 15, 2023

https://hibernate.atlassian.net/browse/HV-1831

this is only a version of #1157 for a main branch with javax->jakarta moved so far.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on licensing, please check here.


Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
6.6% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

HV-1831 Create ProcessedBeansTrackingVoter contract

This contract allows to override the default bean process tracking
behavior without exposing our internal structures.

It needs a bit more love on the config side so that we can define it via
XML too and some documentation.

HV-1831 New zero cost approach to processed bean tracking strategy

I removed it from the traditional VF for now as I would like us to focus
on the case where it is useful first.

We will reintroduce it later once we have validated the approach where
it is the most useful.

I'm a bit unclear right now if we should use the same contract for
traditional and predefined scope VF as we are dealing with different
things and they won't be evaluated at the same moment.

I'm thinking that maybe this needs to be a different contract.

HV-1831 : Wrap a `BeanMetaData` in a `NonTrackedBeanMetaDataImpl` if tracking is not required

HV-1831 Add some guidance about next step

HV-1831 Specific benchmark infrastructure for predefined scope

HV-1831 : Update Cascade tests to use PredefinedScopeHibernateValidator with -p=predefined=true

HV-1831 : Experiment detecting cycles in bean classes

Add test for Map

HV-1831 : Experiment detecting cycles in bean classes

Add support for containers; add tests for List w/ and w/o duplicated values

HV-1831 : Experiment detecting cycles in bean classes

HV-1831 Copy nodes when changing the nature of the leaf

HV-1831 Add the same bean to List twice

HV-1831 Clean up another experiment that shouldn't have been committed

HV-1831 Add a couple of examples illustrating various cases

HV-1831 Unfinished experiments
@marko-bekhta marko-bekhta force-pushed the feat/HV-1831-experiments-8-0 branch from 39b70af to 33dc3e4 Compare May 5, 2025 06:44
@hibernate-github-bot
Copy link
hibernate-github-bot bot commented May 5, 2025

Thanks for your pull request!

This pull request appears to follow the contribution rules.

› This message was automatically generated.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
79.9% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0