Upgrade Vert.x to 4.5.15 (from 4.5.14) #2262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually... @yrodiere can I merge this in 3.0 or should I wait? I will wait for Quarkus before I upgrade 2.4 |
|
It doesn't look like you had to change any code, so I expect that even after the upgrade, Hibernate Reactive will still work in Quarkus, even if it overrides the Vert.x dependencies to 4.5.14... no? |
|
It requires no changes in Hibernate Reactive, but with Quarkus I never know. |
|
Feel free to merge, we can always delay the upgrade to Reactive 3 in Quarkus until the vertx upgrade if this turns out to be a problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2261
We should wait until Quarkus upgrades this too
See https://github.com/quarkusio/quarkus/blob/4abbcf233f6e75bc86ab070ad3d40ada0502e0e3/bom/application/pom.xml#L114