Adding some try catch to various places that cause hard errors, espec…#10
Adding some try catch to various places that cause hard errors, espec…#10chrisschaub wants to merge 1 commit intoheytrav:masterfrom chrisschaub:master
Conversation
…ially for empty buffers; fixing issue with parseInt and listen port on command line not being set; fixed issue with namespaces from config not being correctly passed to the epp xml building code; nameservers are technically optional for createDomain; more try catch is necessary along with recovery for timeouts
|
The change to the way namespaces are passed is something I would like to have verified with other registries as it is currently breaking the tests. The current implementation worked fine when I used it in the past and no other users have reported issues with it (yet). If indeed it is valid, then the tests should also be updated accordingly. Otherwise, it looks ok to me. I would just like to see the tests passing before I merge. |
|
The problem I noticed is that the previous code was not honoring the On Sat, Nov 12, 2016 at 11:52 AM, William Travis Holton <
Christopher Schaub |
Adding some try catch to various places that cause hard errors, especially for empty buffers; fixing issue with parseInt and listen port on command line not being set; fixed issue with namespaces from config not being correctly passed to the epp xml building code; nameservers are technically optional for createDomain; more try catch is necessary along with recovery for timeouts